Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

92030: Remove unused IPF callback endpoint logic #19440

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

92030: Remove unused IPF callback endpoint logic #19440

wants to merge 3 commits into from
+0 −255

Conversation

balexandr
Copy link
Contributor

@balexandr balexandr commented Nov 13, 2024 •
edited by wayne-weibel
Loading

Remove any and all logic around this unused (and never used) feature.

Summary

Remove the following:

  • Endpoint in routes.rb
  • pension_ipf_callbacks_controller.rb
  • PensionIpfNotification model
  • Modle factory
  • Modle spec
  • pension_ipf_vanotify_status_callback in settings.yml and test.yml and features.yml
  • Rspec file

Related issue(s)

@balexandr balexandr mentioned this pull request Nov 13, 2024
Open
4 tasks
@wayne-weibel wayne-weibel mentioned this pull request Nov 14, 2024
Draft
@wayne-weibel wayne-weibel marked this pull request as ready for review November 14, 2024 17:03
@wayne-weibel wayne-weibel requested review from a team as code owners November 14, 2024 17:03
@wayne-weibel wayne-weibel enabled auto-merge (squash) November 14, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wayne-weibel wayne-weibel wayne-weibel approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balexandr @wayne-weibel @va-vfs-bot