-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10-10EZ/10-10EZR] Temporarily disable BGS call for the COLA update weekend #19444
base: master
Are you sure you want to change the base?
Conversation
…e plan to use this for a planned outage.
@@ -15,6 +15,7 @@ | |||
let(:current_user) { build(:ch33_dd_user) } | |||
|
|||
before do | |||
Flipper.disable(:hca_disable_bgs_service) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toggles are enabled by default in specs, so disabling it here to keep the specs consistent.
Sorry for the random comment, just saw this and I was curious, will this show Veterans that their disability is zero percent? |
@bosawt Yes, at least when calling this specific endpoint from our forms. We use this to populate it on the front end, but there are also other places on the form for the Veteran to self report their disability rating. We only intend to use this this weekend so we don't call the BGS service when we know it will be down. Right now, if BGS service returns an error/fails we treat it as returning a 0 disability rating on the front end. So functionally this is the same behavior as if we just let the service return the error response. |
Ah ok, makes sense |
Summary
/rating_info
endpoint that allows the endpoint to return a 0 be default instead of calling the underlying BGS service. This will be turned on during a planned BGS outage to prevent calls to the service. Veterans will receive a 0 from this endpoint, but the forms allow them to add their own information later.hca_disable_bgs_service
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
10-10EZ and 10-10EZR
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?