Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10-10EZ/10-10EZR] Temporarily disable BGS call for the COLA update weekend #19444

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

coope93
Copy link
Contributor

@coope93 coope93 commented Nov 13, 2024

Summary

  • This work is behind a feature toggle (flipper): YES
  • Added a flipper toggle to our /rating_info endpoint that allows the endpoint to return a 0 be default instead of calling the underlying BGS service. This will be turned on during a planned BGS outage to prevent calls to the service. Veterans will receive a 0 from this endpoint, but the forms allow them to add their own information later.
  • 10-10 Health Apps
  • Flipper toggle hca_disable_bgs_service

Related issue(s)

Testing done

  • New code is covered by unit tests

Screenshots

Note: Optional

What areas of the site does it impact?

10-10EZ and 10-10EZR

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@@ -15,6 +15,7 @@
let(:current_user) { build(:ch33_dd_user) }

before do
Flipper.disable(:hca_disable_bgs_service)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toggles are enabled by default in specs, so disabling it here to keep the specs consistent.

@coope93 coope93 marked this pull request as ready for review November 13, 2024 18:17
@coope93 coope93 requested review from a team as code owners November 13, 2024 18:17
@va-vfs-bot va-vfs-bot temporarily deployed to coope93-add-ability-to-not-call-bgs-service/main/main November 13, 2024 18:27 Inactive
dellerbie
dellerbie previously approved these changes Nov 13, 2024
@bosawt
Copy link
Contributor

bosawt commented Nov 13, 2024

Sorry for the random comment, just saw this and I was curious, will this show Veterans that their disability is zero percent?

@coope93
Copy link
Contributor Author

coope93 commented Nov 13, 2024

Sorry for the random comment, just saw this and I was curious, will this show Veterans that their disability is zero percent?

@bosawt Yes, at least when calling this specific endpoint from our forms. We use this to populate it on the front end, but there are also other places on the form for the Veteran to self report their disability rating. We only intend to use this this weekend so we don't call the BGS service when we know it will be down. Right now, if BGS service returns an error/fails we treat it as returning a 0 disability rating on the front end. So functionally this is the same behavior as if we just let the service return the error response.

@bosawt
Copy link
Contributor

bosawt commented Nov 13, 2024

Sorry for the random comment, just saw this and I was curious, will this show Veterans that their disability is zero percent?

@bosawt Yes, at least when calling this specific endpoint from our forms. We use this to populate it on the front end, but there are also other places on the form for the Veteran to self report their disability rating. We only intend to use this this weekend so we don't call the BGS service when we know it will be down. Right now, if BGS service returns an error/fails we treat it as returning a 0 disability rating on the front end. So functionally this is the same behavior as if we just let the service return the error response.

Ah ok, makes sense

Mitch-A6
Mitch-A6 previously approved these changes Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants