-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
96000 part a eps service #19451
base: master
Are you sure you want to change the base?
96000 part a eps service #19451
Conversation
Creating eps provider service
Added specs and service provider update
Eps service initial
Moved files, set settings, removed code we won't be using
Token service not in yet, skipping tests for this service
# frozen_string_literal: true | ||
|
||
module EPS | ||
class BaseService < VAOS::SessionService |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, we're not gaining anything by inheriting from VAOS::SessionService
. Rather we should just inherit from Common::Client::Base
. We should also have a different statsd prefix to not confuse 'api.vaos'
metrics.
@@ -2,7 +2,7 @@ hostname: 127.0.0.1:3000 # possible fallback for unsafe request.host | |||
|
|||
vsp_environment: localhost | |||
|
|||
virtual_hosts: ["127.0.0.1", "localhost"] # Safe host names | |||
virtual_hosts: [ "127.0.0.1", "localhost" ] # Safe host names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would suggest avoiding the automatic IDE pretty-fying
Update to use BaseService
Summary
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?