Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VI-762] Fully destroying User redis on login so that specific fields don't persist between logins #19456

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bosawt
Copy link
Contributor

@bosawt bosawt commented Nov 13, 2024

Summary

  • This PR destroys the User redis when a user authenticates either through SSOe or SiS
  • Previous to this change, specific attributes on the User model were persisting between logins in certain cases

Related issue(s)

Testing done

  • Logged in with a user, then changed attribute needs_accepted_terms_of_use on User model from false to true and saved the record
  • Logged in with the same user again, confirmed needs_accepted_terms_of_use was properly set to false

What areas of the site does it impact?

Authentication

Acceptance criteria

  • Before PR changes, authenticate with a user, change needs_accepted_terms_of_use or credential_lock field on User model that's created
  • Log in again without logging out (use an incognito browser to be able to create a different session)
  • Confirm that the changed field is the original value, not the new value that was set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants