Skip to content

vets-api/v0.0.1406

Compare
Choose a tag to compare
@va-bot va-bot released this 12 Apr 17:03
· 10843 commits to 30481ad217722a14f25eda93e5a9b8476efedfc9 since this release

Release 0.0.1406 ami-0843c165e0f9d2125

1b86f75 Log error to sentry if invalid SSN or File Number sent to BGS create_person endpoint. (#12379)

It looks like many, if not all, of the errors described in department-of-veterans-affairs/va.gov-team#56333 result from a failed request to a BGS create_person (vnp_person_create, to be exact) endpoint containing the following error message: "File Number and Social Security number are different". I examined a small sample of these errors and saw that in each case a file number was present, but a series of eight asterisks were displayed in place of the ssn. I am unsure whether this means the SSN was present, or if the SSN could have been blank, or if the SSN was eight digits instead of nine. If the latter, then we may have to require veterans to have an SSN before filling out the 686c form (if that validation/check isn't done already). If the former, then we will have to figure out what to do about BGS's validation.

To help us answer this question, this PR notifies Sentry if the SSN (or file number) is absent or if the SSN is not nine digits.

As an additional note, if a file number is supposed to be the same as an SSN, then it is problematic that BGS is returning the file_number in their error response, and it is problematic that we are logging it. We will have to follow up on that. Here is a ticket for that: department-of-veterans-affairs/va.gov-team#56528.

240e102 Adds flag for MEB applications to gate minor changes (#12337)

4ca83f9 VA-12984: Add notes on running Hybrid setup (#12361)

023cb59 Add notes for installing and setting up RVM (#12360)

ea907b8 Vfep 361 final - 5490 spool file changes (child type, educ history, school selection) (#12383)

  • fix tests after updating json-schema to include guardian

  • modify school selection and update tests

  • fix Gemfile.lock

  • nokogiri fix

f7e0694 API-25080: Add New 'potentialPactAct' Boolean Field to Supplemental Claims (#12346)

  • API-25080: Add 'potentialPactAct' boolean field to SC schema

  • API-25080: Remove extra brace

  • API-25080: Improve specs

  • API-25080: Update Supplemental Claims V2/V0 schema and docs for potentialPactAct field

  • Fix rubocop offense


Co-authored-by: Drew Fisher [email protected]

f377ded Api 25551 nil bgs claims (#12378)

  • Handle nil BGS claims

  • Add test


Co-authored-by: Austin Covrig [email protected]

30481ad Api 25272 tracked items dates (#12357)

  • Add requested and received dates

  • Update tracked items from discussion

  • Point to date_open

  • Fix merge conflict

  • Remove extra if


Co-authored-by: Austin Covrig [email protected]