vets-api/v0.0.1408

Release 0.0.1408 ami-0a5f7f946d1e49dc7

46a0a22 [56520] Monkeypatching StatsD::Instrument functions to replace StatsD key strings, dots with underscores (#12392)

Co-authored-by: Trevor Bosaw [email protected]

vets-api/v0.0.1407

Release 0.0.1407 ami-0772d2de3c00e100b

f3a0737 Update Appeal info to actually show examples and also add example types for the two docket types (#12381)

74670d5 resolves nil upload_date (#12384)

8054bd4 Api 25788 update tracked item to (#12386)

• Initial commit

• Add swagger after rake re-run

a0b8a11 Vanotify - Change in progress reminder table (#12396)

66999b9 API-25677 - New appeals scopes (#12364)

• Update appeals APIs with revised scopes

• Update appeals API docs with revised scopes

vets-api/v0.0.1406

Release 0.0.1406 ami-0843c165e0f9d2125

1b86f75 Log error to sentry if invalid SSN or File Number sent to BGS create_person endpoint. (#12379)

It looks like many, if not all, of the errors described in department-of-veterans-affairs/va.gov-team#56333 result from a failed request to a BGS create_person (vnp_person_create, to be exact) endpoint containing the following error message: "File Number and Social Security number are different". I examined a small sample of these errors and saw that in each case a file number was present, but a series of eight asterisks were displayed in place of the ssn. I am unsure whether this means the SSN was present, or if the SSN could have been blank, or if the SSN was eight digits instead of nine. If the latter, then we may have to require veterans to have an SSN before filling out the 686c form (if that validation/check isn't done already). If the former, then we will have to figure out what to do about BGS's validation.

To help us answer this question, this PR notifies Sentry if the SSN (or file number) is absent or if the SSN is not nine digits.

As an additional note, if a file number is supposed to be the same as an SSN, then it is problematic that BGS is returning the file_number in their error response, and it is problematic that we are logging it. We will have to follow up on that. Here is a ticket for that: department-of-veterans-affairs/va.gov-team#56528.

240e102 Adds flag for MEB applications to gate minor changes (#12337)

4ca83f9 VA-12984: Add notes on running Hybrid setup (#12361)

023cb59 Add notes for installing and setting up RVM (#12360)

ea907b8 Vfep 361 final - 5490 spool file changes (child type, educ history, school selection) (#12383)

• fix tests after updating json-schema to include guardian

• modify school selection and update tests

• fix Gemfile.lock

• nokogiri fix

f7e0694 API-25080: Add New 'potentialPactAct' Boolean Field to Supplemental Claims (#12346)

• API-25080: Add 'potentialPactAct' boolean field to SC schema

• API-25080: Remove extra brace

• API-25080: Improve specs

• API-25080: Update Supplemental Claims V2/V0 schema and docs for potentialPactAct field

• Fix rubocop offense

---

Co-authored-by: Drew Fisher [email protected]

f377ded Api 25551 nil bgs claims (#12378)

• Handle nil BGS claims

• Add test

---

Co-authored-by: Austin Covrig [email protected]

30481ad Api 25272 tracked items dates (#12357)

• Add requested and received dates

• Update tracked items from discussion

• Point to date_open

• Fix merge conflict

• Remove extra if

---

Co-authored-by: Austin Covrig [email protected]

vets-api/v0.0.1405

Release 0.0.1405 ami-0c03450925ad8931a

8a50db4 Add Additional Logging to VAForms::FormReloader Job (#12365)

• Add additional logging to form reloader job

• Fix key name that was incorrect

ccec1cd Fixed cronjob syntax (#12366)

Co-authored-by: rccassity [email protected]

00f4652 12402 income limits mocked endpoint module setup (#12333)

• income limits module init

• mocked model and data and request test

• gemfile.lock fix

• lint cleanup

• gemfile error

286eae6 [56048] Mockdata sync api (#12335)

• Create mockdata sync add dev route/controller

• Update endpoint and service

3ed4928 Fix mockdata authorize (#12369)

255c8b2 Improved Error Handling for VAForms::FormReloader Job (#12370)

• Add specific error handling around method currently failing silently in EKS Sidekiq env

vets-api/v0.0.1404

Release 0.0.1404 ami-059ca084a71364e17

f3c6e62 Update tracked item display name, associated documentation (#12355)

• Update tracked item display name, associated documentation

• Remove unused block arg, update spec test for displayName

bea8e2e Api 25151 Fix PreviousPhases Completion Dates (#12349)

• Working implementation

• Rubocop fixes

• Fix order of lc status items in test factory

• Rubocop fix for array alignment

ca79b8a VaNotify - Add email confirmation for 1990e (#12354)

53773e9 Api 25504 contention objects (#12340)

680e0d3 Api 25682 tracked item desc (#12351)

b9b2c21 Add migration to track in progress reminders that have been sent (#12348)

vets-api/v0.0.1403

Release 0.0.1403 ami-0337c6f22af86858d

533d93e [54959] mocked MPI profile refactor (#12299)

• changes mpi_profile to profile

• updates mpi_profile creation & removes stub_mpi parameter calls

• updates mvi_profile factory to mpi_profile

• further mvi_profile renaming

• updates claims_api spec

vets-api/v0.0.1402

Release 0.0.1402 ami-0e61570623a95593d

3d696aa 5090 vaos unauthorized exception (#12350)

• 5090: increase VAOS user session extension buffer to prevent VAMF 401 responses

e85f107 Back-End: Board Of Appeals letter support for CST DDL (#12329)

• added Board Of Appeals letter support for CST DDL and put it behind a feature flag

• updated mobile team's rspec test after adding new entry in test data

2764366 Adding extra metadata to supplemental claims (#12352)

• Adding extra meta-data

• Changing source too, vets.gov is outdated

f3b857a updated schema for 40-10007 (#12353)

• updated schema

• MBMS-40433 update schema hash

vets-api/v0.0.1401

Release 0.0.1401 ami-0f10658abf360bba3

8d08237 Add migrations initializer to va_notify module (#12334)

5d8e0bf Update dry-logic to 1.5 (#12338)

4f6a201 remove secondary contact (#12336)

f347de0 5242: add puerto rico timezone to mobile appointments model (#12339)

3f49db8 [12341] Fix breaking specs from Webhooks Utilities classes (#12342)

Co-authored-by: Trevor Bosaw [email protected]

37209c6 Direct deposit swagger docs (#12345)

• Add swagger docs and specs and update routes

• Fix failing specs for lighthouse direct deposit error_spec

• Fixed request body for updates

2fda830 API-25179: Add newer team members to Appeals and Benefits Intake reports (#12347)

vets-api/v0.0.1400

Release 0.0.1400 ami-0c0e693136c891533

254b83f Fix flaky test (#12326)

• Disable flaky test

• Adding drain

• Fixing glaky test

f405cbc API-24184-missing-participant-id (#12103)

• Adds catch for missing participant_id, and a test

• Eliminatess nil values in the array of pids

• Reworks test

---

Co-authored-by: Alexander Wilson [email protected]

86c8373 Direct deposit swagger docs (#12324)

• Add swagger docs and specs and update routes

• Fix failing specs for lighthouse direct deposit error_spec

c6d3322 FIX: updated lookups to take into account various types of appointments (#12327)

• FIX: updated lookups to take into account various types of appointments

• added change to prevent find_npi from returning non npi values when practitioners are presents with no npi

54e587d 56098 VANotify: add send_sms method (#12318)

• 56098 VANotify: add send_sms method

• 56098 add sms_sender_id to the spec

43a456f Add insomnia config for appeals_api (#12323)

Requires the repo-sync-3 insomnia plugin

ed7df0d MHV-41341: fixed font import case error (#12330)

17d44e7 API-24392: Move VBADocuments Slack alerts to different Slack channel (#12311)

• API-24392: Move VBADocuments Slack alerts to different Slack channel

• API-24392: Small refactor to include more under conditional

• API-24392: Refactor to fix rubocop too many lines offense

• API-24392: Remove temporary/fake VAForms feature that was used for testing

• API-24392: Fix VAForms Flipper status alert specs

c5b7f9e Api 25259 faraday bgs itf part2 (#12287)

• Incremental commit

• Rubocop

• Incremental commit

• Handle empty response from local BGS

• Handle response array from BGS findIntentToFileByPtcpntIdItfTypeCd

• Update ITF tests to use LocalBGS

• Rubocop corrections

• Restore Gemfile.lock

• Rubocop fix

• Handle single hash returned from BGS, add check for nil

• Rubocop fix

• Add guard against unnecessary target_veteran calls

• Add downcase to type param in error message

vets-api/v0.0.1399

Release 0.0.1399 ami-020b64523ee1c43d9

102d07b API-24392: Modify VBADocuments Feature Flag Slack Alert (#12312)

• API-24392: Don't alert Slack if Benefits Intake enabled features config is empty

5b2dd68 'API-25271-tracked-items-uploaded-always-false (#12275)

• Replaces 'rcvd_dt' with 'received_dt'

• Changes logic to use present?

• Corrects 'receive_dt', and gets some uploaded tracked items as true

• Changes order of tracked item attributes

• rubocop changes

---

Co-authored-by: FonzMP [email protected]

ea175e9 add feature toggle (#12319)

75a89b4 add users for authd experience team (#12310)

• add users for authd experience team

• undo formatting

• update users without formatting

• newline

c92e140 Update va_facilities.rb (#12320)

Fixing incorrect timezone code for facilty 672

ff176d4 Add tracking for appointment type (#12317)

482b8f5 Update appeals API routes to comply w/Lighthouse standards (#12131)

• Appeals route updates to comply w/Lighthouse standards

This adds new aliases for all routes in the following appeals APIs:

• Notice of disagreements v0
• Supplemental claims v0
• Higher-level reviews v0
• Contestable issues v0
• Legacy appeals v0
• Appeals status v1

The new aliases are compliant with Lighthouse path standards and will be
the ones we use going forward. The old routes continue to work for now
but will be removed.

• Avoid importing route concerns in main routes.rb

• Remount appeals engine at /

• Mount hyphenated routes at /appeals again

509eb5c API-24329-tracked-item-needed-status (#12309)

• Break out needed status to from you/from others, fix receive_dt typo

• Update schema & add swagger, fix for string conversion bug

• Rubocop fixes

8d3b047 Supplemental Claims post launch improvements (#12325)

• Syncing up and adding linking logging to paint a more complete and cohesive picture in the logs

• Adding type to shared DR eviodence logging

ea9f964 vfep-386-final - add guardian fields to spool file (#12322)

• upgrade ruby version and guardian info

• fix rubocop errors

• fix gemfiles

• fix time rubocop issue

• fix spacing issue

• update json schema to point to latest commit on master branch

• update json schema to point to latest commit on master branch 2nd attempt

---

Co-authored-by: nfstern02 [email protected]

b3cdf17 Adjust when json middleware runs (#12290)

• Adjust response json parsing content-type

We use the Faraday json middleware to automatically parse json responses
to Ruby hashes. This wasn't working when trying to hit an endpoint that
downloads a PDF. Even though Faraday docs for this say it defaults to
only parsing application/json content-types, there was a subtle way in
which the lighthouse api returns its content type: Content-Type: application/json;charset-UTF8. The default for the json middleware was
set to /\bjson$/ which only matches if the content type ends in
json.

569690f Mhv 41341 download immunizations fixes (#12328)

• MHV-41341: Download immunizations auth fixes

• MHV-41341: medical records added to statsd middleware

755cd52 API-24392: Add Feature Flag Monitoring Job for VAForms (#12283)

• API-24392: Add feature flag monitoring job for VAForms

• API-24392: Alert using Slack API token and channel ID rather than webhook

• API-24392: Don't alert Slack when enabled features config is empty

• API-24392: Update settings.yml with new VAForms Slack settings

• API-24392: Update correct worker file

2b4f27a Api 23700 add back suspense date (#12321)

• adds suspense_date back

• update oas