Update the 2122 and 2122a schema #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opticbob
commented
Nov 6, 2024
Comment on lines
+11
to
+12
| state_code: { type: 'string', minLength: 2, maxLength: 2 }, | ||
| country: { type: 'string', minLength: 3, maxLength: 3 }, |
There was a problem hiding this comment.
Should I import enums of states and countries here?
There was a problem hiding this comment.
I wrote a custom address object because the backend uses address_line1, 2, etc. Would it make more sense to use the existing hcaAddress object and change the data handling on the backend?
What do you think @cosu419 ?
There was a problem hiding this comment.
Don't think the state/country enums are necessary. hcaAddress was copied from another schema and can probably be replaced.
rmtolmach
approved these changes
Nov 12, 2024
holdenhinkle
approved these changes
Nov 12, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New schema
This is an update to existing schemas for forms 21-22 and 21-22a.
Ticket: department-of-veterans-affairs/va.gov-team#93506
Please ensure you have incremented the version in
package.json.Pull Requests to update the schema in related repositories
After you've merged your changes to vets-json-schema you'll need to make PR's to vets-website and vets-api. Please link them here.