Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove frontend logic for Claims Letters #96918

Open
dysbo opened this issue Nov 12, 2024 · 0 comments · May be fixed by department-of-veterans-affairs/vets-website#33001
Open

Remove frontend logic for Claims Letters #96918

dysbo opened this issue Nov 12, 2024 · 0 comments · May be fixed by department-of-veterans-affairs/vets-website#33001
Assignees
@janechodance
Labels
benefits-management-tools includes Claim Status Tool, Benefits Letters, Payment History bmt-team-2 Benefits Management Tools Team #2

Comments

@dysbo
Copy link

dysbo commented Nov 12, 2024 •
edited
Loading

For the Claims Letters (merged 11/12), it's a similar idea: The frontend code here uses a mapping to transform the description. This conversion is moved to the API, so the frontend can simply display the typeDescription field it receives without mutating it.

Acceptance Criteria

  1. Special logic handling claims letter title mapping is removed from the FE (see link above)
  2. Letter titles are not changed by the removal of this code
@dysbo dysbo added benefits-management-tools includes Claim Status Tool, Benefits Letters, Payment History bmt-team-2 Benefits Management Tools Team #2 labels Nov 12, 2024
@dysbo dysbo changed the title Remove frontend logic 2 Remove frontend logic for Claims Letters Nov 12, 2024
@janechodance janechodance self-assigned this Nov 13, 2024
@janechodance janechodance linked a pull request Nov 13, 2024 that will close this issue
Open
14 tasks
@janechodance janechodance linked a pull request Nov 14, 2024 that will close this issue
remove doc type to description logic in frontend department-of-veterans-affairs/vets-website#33001
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janechodance janechodance

Labels
benefits-management-tools includes Claim Status Tool, Benefits Letters, Payment History bmt-team-2 Benefits Management Tools Team #2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove doc type to description logic in frontend department-of-veterans-affairs/vets-website
2 participants
@dysbo @janechodance