remove doc type to description logic in frontend #33001
Open
+6
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/96918-remove-claims-letters-docTypeToDescription-logic/main
… of https://github.com/department-of-veterans-affairs/vets-website into 96918-remove-claims-letters-docTypeToDescription-logic
iandonovan
approved these changes
Nov 14, 2024
dysbo
approved these changes
Nov 14, 2024
| @@ -76,7 +55,7 @@ const ClaimLetterListItem = ({ letter }) => { | |||
| for accessibility. | |||
| */} | |||
| <span className="vads-u-display--block vads-u-font-size--h4 vads-u-margin-top--3 vads-u-margin-bottom--1"> | |||
| {getDescription(letter.docType)} | |||
| {letter.typeDescription ?? 'Notification letter'} | |||
dysbo
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
remove doc type to description logic in front end as logic is handled by backend.
Related issue(s)
department-of-veterans-affairs/va.gov-team#96918
Testing done
Test locally
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
claims letter page. There is no UI changes
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?