Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authed patterns add mailing address edit page for Orange Task - Pattern 2 #32698

Merged

Conversation

adamwhitlock1
Copy link
Contributor

@adamwhitlock1 adamwhitlock1 commented Oct 24, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Adds the ability to edit the address from the Orange task review page
  • Once the address is updated, then the success alert will show when redirected to the review page again.
  • Removed some unused sections from the code

Related issue(s)

Testing done

  • Added basic e2e test, to make sure task renders. Once the intro alert is updated in 173, then we can add more complete e2e tests.

Screenshots

orange-task-update-address

Screenshot 2024-10-24 at 12 22 58 AM

What areas of the site does it impact?

Authed Patterns Mock Form app

Acceptance criteria

  • Ability to update address is added to Orange task.

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

@va-vfs-bot va-vfs-bot temporarily deployed to master/authed-patterns/aw/175/add-mailing-address-edit-page/main October 24, 2024 18:17 Inactive
@adamwhitlock1 adamwhitlock1 marked this pull request as ready for review October 24, 2024 18:52
@adamwhitlock1 adamwhitlock1 requested review from a team as code owners October 24, 2024 18:52
@va-vfs-bot va-vfs-bot temporarily deployed to master/authed-patterns/aw/175/add-mailing-address-edit-page/main October 24, 2024 19:19 Inactive
Copy link
Contributor

@bellepx0 bellepx0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamwhitlock1 adamwhitlock1 merged commit 02268ea into main Oct 25, 2024
69 of 70 checks passed
@adamwhitlock1 adamwhitlock1 deleted the authed-patterns/aw/175/add-mailing-address-edit-page branch October 25, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants