Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mhv 64024 integrate rx filter endpoints #32996

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

robertbylight
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

integrated the filter fetch from vets-api instead of using mock data
added filter pagination to redux flow

Related issue(s)

Integrate front end and back end for filter work.
image

Testing done

manually made sure the data was coming through

Screenshots

What areas of the site does it impact?

MHV medications

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@robertbylight robertbylight requested review from a team as code owners November 13, 2024 16:20
@va-vfs-bot va-vfs-bot temporarily deployed to master/mhv-64024-integrate-rx-filter-endpoints/main November 13, 2024 16:46 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/mhv-64024-integrate-rx-filter-endpoints/main November 13, 2024 19:28 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/mhv-64024-integrate-rx-filter-endpoints/main November 14, 2024 18:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants