Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading adjustments to AE Design Patterns app Pattern 2 - Orange task #33000

Merged

Conversation

adamwhitlock1
Copy link
Contributor

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Update heading levels in the Orange Task Intro page so that the hierarchy of headings is not broken when logged in and viewing the page.
  • Updated app name to be plain language and to reflect the other PR I have in for Content Build.

Related issue(s)

Testing done

  • Tested locally
  • Used headings map chrome extension to verify heading levels

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Logged out heading levels
Screenshot 2024-11-13 at 10 03 09 AM

Logged in heading levels
Screenshot 2024-11-13 at 10 03 25 AM

What areas of the site does it impact?

AE design patterns app, non-prod

Acceptance criteria

Headings updated

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Copy link
Contributor

@bellepx0 bellepx0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamwhitlock1 adamwhitlock1 merged commit b6fc2da into main Nov 14, 2024
71 checks passed
@adamwhitlock1 adamwhitlock1 deleted the authed-patterns/aw/163/update-orange-intro-heading-levels branch November 14, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants