Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask VA/ 1475 update require sign in logic #33003

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import FormNavButtons from '~/platform/forms-system/src/js/components/FormNavButtons';
import RequireSignInModal from '../components/RequireSignInModal';
import SignInMayBeRequired from '../components/SignInMyBeRequired';
import { flowPaths } from '../config/schema-helpers/formFlowHelper';

Check warning on line 10 in src/applications/ask-va/containers/WhoIsYourQuestionAboutCustomPage.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/ask-va/containers/WhoIsYourQuestionAboutCustomPage.jsx:10:1:Dependency cycle via ../chapters/personalInformation/familyMembersPostalCode:26=>../../../components/PageFieldSummary:2=>../config/form:4
import {
CategoryEducation,
CHAPTER_2,
Expand All @@ -16,16 +16,10 @@
} from '../constants';

const WhoIsYourQuestionAboutCustomPage = props => {
const { onChange, loggedIn, goBack, goToPath, formData } = props;

Check warning on line 19 in src/applications/ask-va/containers/WhoIsYourQuestionAboutCustomPage.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/ask-va/containers/WhoIsYourQuestionAboutCustomPage.jsx:19:31:'goBack' is missing in props validation

Check warning on line 19 in src/applications/ask-va/containers/WhoIsYourQuestionAboutCustomPage.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/ask-va/containers/WhoIsYourQuestionAboutCustomPage.jsx:19:39:'goToPath' is missing in props validation

Check warning on line 19 in src/applications/ask-va/containers/WhoIsYourQuestionAboutCustomPage.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/ask-va/containers/WhoIsYourQuestionAboutCustomPage.jsx:19:49:'formData' is missing in props validation
const [validationError, setValidationError] = useState(null);
const [showModal, setShowModal] = useState({ show: false, message: '' });

const caregiverSelected = {
category: 'Health care',
topic: 'Caregiver support program',
subtopic: 'Program of General Caregiver Support Services (PGCSS)',
};

const radioOptions = () => {
const labels = Object.values(whoIsYourQuestionAboutLabels);
const values = Object.keys(whoIsYourQuestionAboutLabels);
Expand Down Expand Up @@ -57,9 +51,6 @@
const selectedValue = event.detail.value;
onChange({ ...formData, whoIsYourQuestionAbout: selectedValue });
if (
formData.selectCategory === caregiverSelected.category &&
formData.selectTopic === caregiverSelected.topic &&
formData.selectSubtopic === caregiverSelected.subtopic &&
!loggedIn &&
(selectedValue === whoIsYourQuestionAboutLabels.MYSELF ||
selectedValue === whoIsYourQuestionAboutLabels.SOMEONE_ELSE)
Expand Down Expand Up @@ -99,9 +90,9 @@
name="who-is-your-question-about"
label={option.label}
value={option.label}
checked={formData.whoIsYourQuestionAbout === option.value}

Check warning on line 93 in src/applications/ask-va/containers/WhoIsYourQuestionAboutCustomPage.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/ask-va/containers/WhoIsYourQuestionAboutCustomPage.jsx:93:33:'formData.whoIsYourQuestionAbout' is missing in props validation
aria-describedby={
formData.whoIsYourQuestionAbout === option.value

Check warning on line 95 in src/applications/ask-va/containers/WhoIsYourQuestionAboutCustomPage.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/ask-va/containers/WhoIsYourQuestionAboutCustomPage.jsx:95:26:'formData.whoIsYourQuestionAbout' is missing in props validation
? option.value
: null
}
Expand Down
Loading