-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DR | Update confirmation page #33007
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint is disabled
vets-website
uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.
What you can do
See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.
<h3 className="vads-u-margin-top--2">Issues for review</h3> | ||
{/* Adding a `role="list"` to `ul` with `list-style: none` to work around | ||
a problem with Safari not treating the `ul` as a list. */} | ||
{/* eslint-disable-next-line jsx-a11y/no-redundant-roles */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint disabled here
</div> | ||
{/* Adding a `role="list"` to `ul` with `list-style: none` to work around | ||
a problem with Safari not treating the `ul` as a list. */} | ||
{/* eslint-disable-next-line jsx-a11y/no-redundant-roles */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint disabled here
This PR is dependent on #32982 - DO NOT MERGE BEFORE! |
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Related issue(s)
department-of-veterans-affairs/va.gov-team#95199
Testing done
Screenshots
What areas of the site does it impact?
NOD confirmation page
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?