-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditions 629 Autocomplete Move Focus into List #33010
Merged
williamphelps13
merged 8 commits into
main
from
conditions-629-autocomplete-focus-in-list
Nov 14, 2024
Merged
Conditions 629 Autocomplete Move Focus into List #33010
williamphelps13
merged 8 commits into
main
from
conditions-629-autocomplete-focus-in-list
Nov 14, 2024
+61
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WS a11y issue Replace onBlur with eventListener that closes list only if click outside container and add tabIndex so that focus can go on list items. Ensure any key press other than arrow up/down, enter, or escape, brings focus back to input. Add focus onMouseEnter so that highlight and focus are always aligned. Remove search onFocus functionality since this was firing with stale data whenever focusOnInput ran. Need to determine how to add back this functionality.
bacitracin
reviewed
Nov 13, 2024
src/applications/disability-benefits/all-claims/components/Autocomplete.jsx
Outdated
Show resolved
Hide resolved
va-vfs-bot
temporarily deployed
to
master/conditions-629-autocomplete-focus-in-list/main
November 14, 2024 05:23
Inactive
bacitracin
reviewed
Nov 14, 2024
src/applications/disability-benefits/all-claims/components/Autocomplete.jsx
Show resolved
Hide resolved
va-vfs-bot
temporarily deployed
to
master/conditions-629-autocomplete-focus-in-list/main
November 14, 2024 16:37
Inactive
bacitracin
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
williamphelps13
deleted the
conditions-629-autocomplete-focus-in-list
branch
November 14, 2024 19:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)