Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[96835] [96855] Add org select requirement and show selection #33015

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jvcAdHoc
Copy link
Contributor

@jvcAdHoc jvcAdHoc commented Nov 14, 2024

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • This pr adds validation to organization selection to force users to select an option
  • This pr adds the checked attribute to the radio buttons to show users their selection when navigating backwards

Related issue(s)

Testing done

  • Went through flow locally with all rep types options as well as through the review page to confirm expected behavior

Screenshots

Before

Screen.Recording.2024-11-14.at.8.41.38.AM.mov

After

Screen.Recording.2024-11-14.at.9.08.36.AM.mov

What areas of the site does it impact?

Appoint a Rep Form 21-22 and 21-22a

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@jvcAdHoc jvcAdHoc added the appoint-a-representative Benefits Representation Management product label label Nov 14, 2024
@jvcAdHoc jvcAdHoc self-assigned this Nov 14, 2024
@jvcAdHoc jvcAdHoc changed the title add org select requirement and show selection [96835] [96855] Add org select requirement and show selection Nov 14, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/96835-user-can-continue-without-selecting-an-organization-on-representative-organization/main November 14, 2024 14:15 Inactive
@jvcAdHoc jvcAdHoc marked this pull request as ready for review November 14, 2024 14:43
@jvcAdHoc jvcAdHoc requested a review from a team as a code owner November 14, 2024 14:43
@jvcAdHoc jvcAdHoc requested a review from a team November 14, 2024 14:43
holdenhinkle
holdenhinkle previously approved these changes Nov 14, 2024
Copy link
Contributor

@harshil1793 harshil1793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the new code at line 10 introduces a new linting warning. Can we please clean those up before we merge this?

@jvcAdHoc jvcAdHoc force-pushed the 96835-user-can-continue-without-selecting-an-organization-on-representative-organization branch from 336dfb6 to bd48475 Compare November 14, 2024 15:42
@va-vfs-bot va-vfs-bot temporarily deployed to master/96835-user-can-continue-without-selecting-an-organization-on-representative-organization/main November 14, 2024 15:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appoint-a-representative Benefits Representation Management product label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants