Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only call fetchRepStatus if loggedIn #33020

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

holdenhinkle
Copy link
Contributor

@holdenhinkle holdenhinkle commented Nov 14, 2024

Resolves department-of-veterans-affairs/va.gov-team#97172

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Summary

This PR adds a condition before calling fetchRepStatus() (which in turn calls the power_of_attorney endpoint); the user must be logged in.

Related issue(s)

department-of-veterans-affairs/va.gov-team#97172

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

Appoint a Representative, which is currently behind a feature flag.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@holdenhinkle holdenhinkle requested a review from a team as a code owner November 14, 2024 17:01
@cosu419 cosu419 self-requested a review November 14, 2024 17:03
Copy link
Contributor

@cosu419 cosu419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holdenhinkle holdenhinkle merged commit 5921c53 into main Nov 14, 2024
71 checks passed
@holdenhinkle holdenhinkle deleted the hh-only-call-poa-endpoint-if-logged-in branch November 14, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only call fetchRepStatus if loggedIn
4 participants