feat(a11y): remove incorrect expanded attribute on OptionsMenu #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
anastasialanz
approved these changes
Feb 18, 2025
|
I checked out https://w3c.github.io/aria/#aria-expanded and saw that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1791
Normally, we might consider this a breaking change but I think in this instance since we're addressing an accessibility issue where an incorrect aria attribute is being used on a component I think this is a special consideration we need to take to bypass that in this instance.
I will be marking this as a
featto have a major version and will be communicating in the proper channels to ensure everyone is aware of this change.