fix #4139: preserve node pod counting when jumping to node view - #4140
Open
thinkniko wants to merge 1 commit into
Open
fix #4139: preserve node pod counting when jumping to node view#4140thinkniko wants to merge 1 commit into
thinkniko wants to merge 1 commit into
Conversation
Set KeyPodCounting in the browser default context for nodes so navigation still counts pods after context callbacks are overridden.
Contributor
|
@uozalp We previously fixed jumps to only fallback to default browser if target is an unknown gvr #4066. Now this sounds similiar and default context should not be used for known gvr (this would also mean we have to fix context for all other gvr). I think the observed behaviour is coming from the fact that we redefine the parent context function in |
Contributor
Author
|
Which would be the better change for fixing #4139 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set KeyPodCounting in the browser default context for nodes so navigation still counts pods after context callbacks are overridden.