Skip to content

fix #4139: preserve node pod counting when jumping to node view - #4140

Open
thinkniko wants to merge 1 commit into
derailed:masterfrom
thinkniko:fix_issue/4139
Open

fix #4139: preserve node pod counting when jumping to node view#4140
thinkniko wants to merge 1 commit into
derailed:masterfrom
thinkniko:fix_issue/4139

Conversation

@thinkniko

Copy link
Copy Markdown
Contributor

Set KeyPodCounting in the browser default context for nodes so navigation still counts pods after context callbacks are overridden.

Set KeyPodCounting in the browser default context for nodes so
navigation still counts pods after context callbacks are overridden.
@mpas97

mpas97 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

@uozalp We previously fixed jumps to only fallback to default browser if target is an unknown gvr #4066. Now this sounds similiar and default context should not be used for known gvr (this would also mean we have to fix context for all other gvr). I think the observed behaviour is coming from the fact that we redefine the parent context function in custom_jumps.go. Therefore our inherited KeyPodCounting variable is lost there. Commenting out the following lines, makes pod count working again too:

// Set up the context for the jump
v.SetContextFn(func(ctx context.Context) context.Context {
	if fieldSel != "" {
		ctx = context.WithValue(ctx, internal.KeyFields, fieldSel)
	}
	return ctx
})

@thinkniko

Copy link
Copy Markdown
Contributor Author

Which would be the better change for fixing #4139 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants