Non xhtml namespaceuri #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! This being a workaround, we want to think a little harder on the right API. It is a little onerous to ask the user to specify the svg namespace in a partial. A more user-friendly workaround could be specifying that a partial is specifically an svg partial (we don't see much use in having a partial that is both svg and html, might as well keep them separate). We also want to look into properly fixing this so that users dont need to be concerned with the namespace of their partials. Could you put the Travis fix in a separate pull request so we can go ahead and merge that in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the suggested fix for #4, by letting a user set an explicit
xmlnson a tag.This also adds the minimal possible Travis-CI integration.
Definitely interested in feedback!