Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not treat images like links in Internet Explorer. #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

Should not treat images like links in Internet Explorer. #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/History.js
View file
Original file line number Diff line number Diff line change
@@ -155,7 +155,10 @@ function addListeners(history) {
while (el) {
var url = el.href
if (url) {


// Ignore href property on IMG tags because Internet Explorer. (https://github.com/derbyjs/derby/issues/496)
if (el.nodeName === 'IMG') return

// Ignore if created by Tracks
if (el.hasAttribute && el.hasAttribute('data-router-ignore')) return

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@
"type": "git",
"url": "git://github.com/codeparty/tracks.git"
},
"version": "0.5.4",
"version": "0.5.5",
"main": "./lib/index.js",
"browserify": {
"main": "./lib/browser.js"