Update cargo-msrv installation to use --locked

[infrmtcs]

Some of cargo-msrv’s dependencies, notably aws-sdk-s3 and other AWS crates, frequently bump their minimum supported Rust version. As a result, Rust 1.87 cannot install the tool, even though the actual MSRV of this repo is 1.87. We can address this by pinning the dependency versions and using --locked so that cargo install respects the repository’s original Cargo.lock.

[gemini-code-assist]

Summary of Changes

Hello @infrmtcs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue preventing the reliable installation of cargo-msrv in environments with specific Rust versions. By pinning the tool's version and leveraging the --locked flag during installation, it ensures that dependency resolution aligns with the project's Cargo.lock file, thereby maintaining compatibility with the repository's Minimum Supported Rust Version and preventing build failures.

Highlights

• Fix cargo-msrv installation: Addresses an issue where cargo-msrv could not be installed due to its dependencies (e.g., aws-sdk-s3) frequently bumping their Minimum Supported Rust Version (MSRV), causing conflicts with the repository's MSRV.
• Dependency pinning and locking: The installation command for cargo-msrv now uses --locked and explicitly pins the version to 0.18.4. This ensures cargo install respects the repository's Cargo.lock file, preventing MSRV conflicts and ensuring reliable installation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix an issue with cargo-msrv installation by pinning its version to prevent MSRV conflicts with its dependencies. While pinning the version is the correct approach, the addition of the --locked flag to the cargo install command is incorrect as this flag is not supported when installing packages from a registry like crates.io. This would cause the workflow to fail. I've provided a suggestion to remove the flag, which will fix the installation step while keeping the version pinned.