Skip to content

Conversation

@lukaslihotzki
Copy link
Contributor

This PR fixes middle click on agreement links (to open it in a new tab without switching). It also fixes the validation error showing up when just clicking on a link. Furthermore, it makes the code more consistent (use router-link everywhere instead of $router.resolve, use target="_blank" everywhere instead of window.open).

Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one minor question. Otherwise lgtm!

@peterthomassen peterthomassen merged commit 594efb0 into desec-io:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants