Skip to content

Conversation

@jank324
Copy link
Member

@jank324 jank324 commented Sep 12, 2025

Description

Sub- / replacement PR for #538.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)
Screenshot 2025-12-09 at 11 57 59

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line.

@jank324
Copy link
Member Author

jank324 commented Sep 12, 2025

benchmark_commits_plot

@jank324
Copy link
Member Author

jank324 commented Dec 9, 2025

According to the benchmark, the main saving is in not doing the clone. (Event though there is still a meaningful enough saving when cloning.) So the big question is: " Where can we get away with not cloning?" I'm not perfectly sure if we can get away with that everywhere we are currently not cloning.

NOTE: The issue with not cloning is that the repeat tensors all simply view the same data, i.e. changes to one slice affect all slices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants