implement tcav splitting #593
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement TCAV
num_stepsand splittingDescription
Correctly implements TCAV
num_stepsspecification and element splitting in limited cases (num_steps of original element must be odd and greater than 1).Motivation and Context
This is needed for effective tracking in lcls lattices since TCAV elements contain steering elements that are modeled by splitting the TCAV element into 2 parts. This correctly splits the elements by breaking the tracking steps up properly while also correctly scaling the TCAV voltage to maintain correct tracking. This improvement is in conjunction with #591
Types of changes
Checklist
flake8(required).pytesttests pass (required).pyteston a machine with a CUDA GPU and made sure all tests pass (required).Note: We are using a maximum length of 88 characters per line.