Remove PreferToOverPairSyntax #7943
Open
+0
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7943 +/- ##
============================================
- Coverage 85.53% 85.53% -0.01%
+ Complexity 4219 4211 -8
============================================
Files 573 572 -1
Lines 13370 13352 -18
Branches 2540 2538 -2
============================================
- Hits 11436 11420 -16
Misses 658 658
+ Partials 1276 1274 -2 ☔ View full report in Codecov by Sentry. |
schalkms
approved these changes
Feb 14, 2025
|
I would like, at least, one more approve from the maintainers to merge this because we are "loosing" functionality. |
cortinico
added
notable changes
cortinico
approved these changes
Feb 19, 2025
I'm fine with removing it 👍 Haven't received many user reports so far related to this rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7920, the reason of this PR is there.
also closes #7916