Skip to content

Add support for starting container using prebuild #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Eimhin Laverty (eimhin-rover) wants to merge 1 commit into from
Closed

Add support for starting container using prebuild #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ inputs:
cacheTo:
required: false
description: Specify the image to cache the built image to
prebuild:
required: false
default: false
description: Set to true to prebuild the dev container image. This is useful for speeding up the first run of the dev container.
outputs:
runCmdOutput:
description: The output of the command specified in the runCmd input
Expand Down
4 changes: 4 additions & 0 deletions common/src/dev-container-cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ export interface DevContainerCliUpArgs {
env?: string[];
userDataFolder?: string;
additionalMounts?: string[];
prebuild?: boolean;
}
async function devContainerUp(
args: DevContainerCliUpArgs,
Expand Down Expand Up @@ -258,6 +259,9 @@ async function devContainerUp(
commandArgs.push('--mount', mount),
);
}
if (args.prebuild) {
commandArgs.push('--prebuild');
}
return await runSpecCliJsonCommand<DevContainerCliUpResult>({
args: commandArgs,
log,
Expand Down
2 changes: 2 additions & 0 deletions github-action/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export async function runMain(): Promise<void> {
);
const userDataFolder: string = core.getInput('userDataFolder');
const mounts: string[] = core.getMultilineInput('mounts');
const prebuild: boolean = core.getBooleanInput('prebuild');

if (platform) {
const skopeoInstalled = await isSkopeoInstalled();
Expand Down Expand Up @@ -157,6 +158,7 @@ export async function runMain(): Promise<void> {
env: inputEnvsWithDefaults,
userDataFolder,
additionalMounts: mounts,
prebuild: prebuild,
};
const result = await devcontainer.up(args, log);
if (result.outcome !== 'success') {
Expand Down