Skip to content

Address CodeQL warnings#2

Merged
webbnh merged 1 commit intomainfrom
codeql-fixes
Mar 4, 2025
Merged

Address CodeQL warnings#2
webbnh merged 1 commit intomainfrom
codeql-fixes

Conversation

@webbnh
Copy link
Copy Markdown
Contributor

@webbnh webbnh commented Mar 4, 2025

I've enabled CodeQL scanning of this repository, and it has responded with several alerts. Three of them are clearly false positives (which I've reported), and the fourth is arguably a false positive (because the source is not a "user" but a server that we trust).

Nevertheless, to quiet the warnings, I've implemented workarounds here. (And, I also made a small tweak to improve the code.)

Fixes https://github.com/developerproductivity/costpuller/security/code-scanning/1, https://github.com/developerproductivity/costpuller/security/code-scanning/2, https://github.com/developerproductivity/costpuller/security/code-scanning/3, https://github.com/developerproductivity/costpuller/security/code-scanning/4.

@webbnh webbnh requested a review from kpiwko March 4, 2025 18:55
@webbnh webbnh self-assigned this Mar 4, 2025
Copy link
Copy Markdown

@dprod-bot dprod-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@webbnh webbnh merged commit afa3306 into main Mar 4, 2025
@webbnh webbnh deleted the codeql-fixes branch March 4, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants