Feature gate object_store and reqwest

[feefladder]

As discussed in #6, only feature gate and not pulling coalesce_ranges in-tree

[kylebarron]

Can you add to CI variants that test that async-tiff compiles with each combination of features?

You can see how parquet-wasm uses cargo-all-features
https://github.com/kylebarron/parquet-wasm/blob/e85322b592ab224938861895a06f4f3947a77802/Cargo.toml#L117

https://github.com/kylebarron/parquet-wasm/blob/e85322b592ab224938861895a06f4f3947a77802/.github/workflows/test.yml#L38-L41

[feefladder]

just wanted to note: removing object_store from default deps makes tests fail, which is fine

[feefladder]

it was not fine and is fixed now

[kylebarron]

We should not add this because this will perform blocking reads on the main thread.

Instead we should probably restore the tokio integration

async-tiff/src/reader.rs

Lines 70 to 91 in 6a7a2dc

	// #[cfg(feature = "tokio")]
	// impl<T: tokio::io::AsyncRead + tokio::io::AsyncSeek + Unpin + Debug + Send + Sync> AsyncFileReader
	// for T
	// {
	// fn get_bytes(&self, range: Range<u64>) -> BoxFuture<'_, AsyncTiffResult<Bytes>> {
	// use tokio::io::{AsyncReadExt, AsyncSeekExt};
	// async move {
	// self.seek(std::io::SeekFrom::Start(range.start)).await?;
	// let to_read = (range.end - range.start).try_into().unwrap();
	// let mut buffer = Vec::with_capacity(to_read);
	// let read = self.take(to_read as u64).read_to_end(&mut buffer).await?;
	// if read != to_read {
	// return Err(AsyncTiffError::EndOfFile(to_read, read));
	// }
	// Ok(buffer.into())
	// }
	// .boxed()
	// }
	// }

which will allow reading from a tokio async file, which I think performs file IO from a thread pool

[feefladder]

The problem I had was that the feature testing also wants to test with all features disabled, and I didn't exactly know how to deal with that... added a fallback in util.rs

[feefladder]

Also tokio's asyncread require &mut self, so I changed the impl to tokio::fs::File, where we can try_clone() on &self. There doesn't seem to be a TryClone trait

[feefladder]

@kylebarron should be done!

[kylebarron]

Thanks. I updated a couple things:

• We don't need to actually run test on each feature flag. It's fine to just check that it compiles.
• And this adds an adapter struct to work with arbitrary tokio objects so we don't need to concretely implement for a tokio file