Aggresive caching in PrefetchReader #74
Draft
+293
−275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feefladder
force-pushed
the
aggresive-cache
branch
5 times, most recently
from
e2e97f5 to
8513237
Compare
feefladder
force-pushed
the
aggresive-cache
branch
from
8513237 to
2e70f22
Compare
feefladder
force-pushed
the
aggresive-cache
branch
from
2e70f22 to
feefadd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #76
Add a more aggressive caching strategy to PrefetchReader. Main reason is that this is the reason #76 is nice to have. Alternative could be a
CacheReaderso we can build aPrefetchReader<CacheReader<CoalesceReader<MyReader>>>? but that will also fetch double cache for the initial prefetch.I removed the
TODO: partial re-use of internal bufferto make code easier. Now a range is either in the prefetch range or in internal cache