-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Buildout CQL2 filter tooling for reading Items #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b440d73
to
a1db2ba
Compare
a1db2ba
to
e621750
Compare
8c20855
to
08e4f40
Compare
* Refactor API spec augmentation to middleware * Breakout middleware into separate files * Rename middleware * Reorg * chore: reorg imports * Mv auth to middleware, rework url patterns to regex * fix: pass empty chunks while waiting for entirety of body * Rm scope scheck in auth enforcement * typing cleanup * fix: extract user from request state * Rm auth class in favor of middleware * Rework template tooling as dataclass * cleanup: rm unused code * Cleanup * CQL2 Middleware: in progress * In progress * Update tests * Take care to separate GET and POST middleware behavior * Conditionally enable CQL2 filters + cleanup * Add formatting helpers * Test tweaks * Fix querystring parse test util * bugfix: place auth middleware after cql2 middleware to ensure correct order * Allow customizing state key * Minor update to auth token * pre-commit cleanup * Rm unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I'm changing
Application of Item filter
/search
POST
/search
GET
/collections/{collection_id}/items
GET
I've created #21, #22, #23 to track future filter work
closes #9
closes #18