-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HLS tile configuration documentation #45
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
📚 Documentation preview will be available at: https://developmentseed.github.io/titiler-cmr/pr-previews/pr-45/ Status: ✅ Preview is ready! |
@hrodmn Perhaps not in the context of this PR, but could we introduce some additional verbose logging or open telemetry decorators to understand the source of increased latency for larger temporal requests is
Not really critical for our current use cases but would be good to know. |
@hrodmn apologies for the delinquent review. It looks great! I only made a few minor comments, most importantly I think there should be a brief explanation of the benchmarks in the hls tiling notebook. Perhaps just a brief description of the methodology and link to the benchmark tests python file. Apologies if I missed that description somewhere. Also I made a comment on the rasterio notebook and only afterwards noticed only minor changes were made to that existing notebook, I hope you don't mind making that minor change as well. |
I added a pytest-benchmark module with some tile-getting tests so we could evaluate performance across a range of conditions. The goal is to provide a) configuration parameters for consumers who want to add HLS tiles to an application and b) some expectations about rendering performance.
The docs site with the new HLS configuration page is here: https://developmentseed.org/titiler-cmr/pr-previews/pr-45/datasets/hls_tiling/