Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HLS tile configuration documentation #45

Merged
merged 14 commits into from
Mar 25, 2025
Merged

Conversation

hrodmn
Copy link
Contributor

@hrodmn hrodmn commented Mar 17, 2025

I added a pytest-benchmark module with some tile-getting tests so we could evaluate performance across a range of conditions. The goal is to provide a) configuration parameters for consumers who want to add HLS tiles to an application and b) some expectations about rendering performance.

The docs site with the new HLS configuration page is here: https://developmentseed.org/titiler-cmr/pr-previews/pr-45/datasets/hls_tiling/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Mar 17, 2025

📚 Documentation preview will be available at: https://developmentseed.github.io/titiler-cmr/pr-previews/pr-45/

Status: ✅ Preview is ready!

github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
@hrodmn hrodmn requested a review from sharkinsspatial March 17, 2025 19:46
@hrodmn hrodmn self-assigned this Mar 17, 2025
@hrodmn hrodmn marked this pull request as ready for review March 17, 2025 19:48
github-actions bot pushed a commit that referenced this pull request Mar 20, 2025
@sharkinsspatial
Copy link
Member

@hrodmn Perhaps not in the context of this PR, but could we introduce some additional verbose logging or open telemetry decorators to understand the source of increased latency for larger temporal requests is

  1. Purely an earthaccess issue with longer search times or slower, larger response bodies?
  2. Is our band regex slow?
  3. Is the mosaic_reader default pixel selection method slow when scanning many assets?

Not really critical for our current use cases but would be good to know.

@abarciauskas-bgse
Copy link
Contributor

@hrodmn apologies for the delinquent review. It looks great! I only made a few minor comments, most importantly I think there should be a brief explanation of the benchmarks in the hls tiling notebook. Perhaps just a brief description of the methodology and link to the benchmark tests python file. Apologies if I missed that description somewhere.

Also I made a comment on the rasterio notebook and only afterwards noticed only minor changes were made to that existing notebook, I hope you don't mind making that minor change as well.

github-actions bot pushed a commit that referenced this pull request Mar 25, 2025
@hrodmn hrodmn merged commit de89427 into develop Mar 25, 2025
7 checks passed
@hrodmn hrodmn deleted the feat/hls-benchmark branch March 25, 2025 19:39
github-actions bot pushed a commit that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants