Fix catalog cache keys for status/count variants#21
Merged
deverman merged 1 commit intoMar 19, 2026
Conversation
intent(catalog-cache): prevent projects and tags with different status or task-count settings from sharing cached pages decision(catalog-cache): add projects and tags cache-key builders so service call sites generate the same key shape consistently constraint(catalog-cache): keep the existing cache bypass rules and field ordering behavior unchanged for this correctness fix learned(catalog-cache): cache regression coverage is more stable as direct CatalogCache tests than as live OmniFocus integration checks
Owner
|
@osamu2001 thanks for finding this issue I have merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The catalog cache keys for
list_projectsandlist_tagsonly used pagination and fields, so requests with differentstatusFilterorincludeTaskCountsvalues could reuse the same cached page.This change separates those cache entries by filter state and adds regression tests that pin the behavior without relying on live OmniFocus data.
Changes
statusFilterandincludeTaskCountsin catalog cache keysOmniFocusBridgeServiceto use the new key buildersTesting
swift test --filter CatalogCacheTestsswift test