Skip to content

rust: upstream cargo_build_script coverage fix and drop cargo_build_script_no_coverage.patch (follow-up of #12155) #12977

Open

Description

@TrapsterDK

Follow-up of #12155. The macOS coverage gcov_gcno_file failure in cargo_build_script is fixed in rules_dx (#12852, #12856; evidence run 44027858036). Still carried locally as patches/rules_rust/cargo_build_script_no_coverage.patch.

Remaining:

  • Upstream rules_rust PR: in cargo/private/cargo_build_script.bzl, pass coverage features through find_cc_toolchain extra_unsupported_features so build scripts compile without coverage.
  • Upstream apple_support PR: guard the GCOV_GCNO_FILE flag set with expand_if_available = "gcov_gcno_file".
  • After a rules_rust release with the fix: bump rules_rust in MODULE.bazel, drop patches/rules_rust/cargo_build_script_no_coverage.patch, its entry in patches/rules_rust/BUILD.bazel, its row in patches/README.md, and the references in deploy/private/release/tests/BUILD.bazel and tools/testing/nested/src/compose.rs.

Done when: rules_dx builds //rust/tests/fixtures/native_call:native_cc_test under macos_arm64 coverage with no local rules_rust coverage patch.

Activity

  1. added
    P2Improve and finish existing features
    on Nov 17, 2026
  2. TrapsterDK commented on Nov 17, 2026

    @TrapsterDK
    CollaboratorAuthor

    Skipped by agent: the remaining items are PRs to bazelbuild/rules_rust and bazelbuild/apple_support, which agents may not open (scope is devhusdk/rules_dx only). Needed: someone with an upstream account opens those two PRs, using the hunk in patches/rules_rust/cargo_build_script_no_coverage.patch and an expand_if_available = "gcov_gcno_file" guard. The rules_dx cleanup can follow once a rules_rust release includes the fix.

  3. TrapsterDK commented on Nov 18, 2026

    @TrapsterDK
    CollaboratorAuthor

    Upstream opened:

    Assisted by Claude.

  4. TrapsterDK commented on Nov 19, 2026

    @TrapsterDK
    CollaboratorAuthor

    Remaining after #13795: wait for a rules_rust release with bazelbuild/rules_rust#4433 (open) and an apple_support release with bazelbuild/apple_support#693 (merged after 2.12.0); then bump both, delete both patches and their entries in MODULE.bazel, patches/rules_rust/BUILD.bazel, patches/README.md, deploy/private/release/tests/BUILD.bazel, tools/testing/nested/src/compose.rs, and lower RULES_RUST_PATCHES 11 -> 10.

  5. TrapsterDK commented on Nov 19, 2026

    @TrapsterDK
    CollaboratorAuthor

    PR #13795 merged. macOS evidence run 44481715306: //rust/tests/fixtures/native_call:native_cc_test passed under bazel coverage on macos_arm64 ("Executed 1 out of 1 test: 1 test passes."), so the patches apply and build. The job is red only because of the --min-coverage 100 gate ("no executable lines in the owned sources of package macos_arm64"); a test fixture has no owned sources. Remaining: the rules_rust and apple_support bumps once releases contain #4433 and #693, then drop both patches (see the earlier comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Improve and finish existing featuresmodel:opusAgent lane: needs planning or open design, Opus

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions