#404: enhance logging with custom slf4j bridge #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/cli/Ideasy.java
renamed TestLogger to IdeLoggerAdapter added missing param to javadoc renamed TestProvider to TestProviderImpl renamed TestLoggerFactory to TestLoggerFactoryImpl
added first implementations for IdeLoggerAdapter methods replaced IdeSubLoggerSlf4j with IdeSubLoggerOut
added null checks to IdeLoggerAdapter debug methods
added rest of null checks
fixed compose array out of bounds exception
updated WireMock dependency from 2.35.2 to 3.11.0 added jackson-core dependency to ide-cli added url namespace to tools added LogbackServiceProvider to service
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/log/AbstractIdeSubLogger.java
Closed
jan-vcapgemini
changed the title
jan-vcapgemini
changed the title
|
CI failed because of concurrent modification in |
yurii-yu
reviewed
Feb 6, 2025
There was a problem hiding this comment.
maybe we need to re-format the code?
There was a problem hiding this comment.
Had to enforce the reformat using CTRL+SHIFT+S.
Adjusted now.
applied reformat
# Conflicts: # cli/pom.xml # cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
Pull Request Test Coverage Report for Build 13788808942Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #404
Continues PR: #760 by @KianRolf
Implements:
com.devonfw.ide.tools.urlintourl-updatermodule (kept package names)WireMockdependency from 2.35.2 to 3.11.0jackson-coredependency toide-cliurlnamespace totoolsLogbackServiceProviderto url-updater serviceIdeLoggerAdapter(bridge class for slf4j)