-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isExpectedFolder(): log level now generic with default being WARNING #1118
Conversation
Pull Request Test Coverage Report for Build 13859769305Details
💛 - Coveralls |
The changes look good to me.
|
@ssmid Andre, please update your feature branch. I do not have permission to do so for your PR, it seems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssmid thanks for your PR. You even followed the trace from my comment and tried to implement this properly. 👍
However, I have to crush the party here.
I was confused why the error message should be fixed by this PR as this did not make sense to me.
Then I tried to reproduce the issue and figured out that it cannot be reproduced any-more with or without this PR.
I tried to find an explanation for this and found it in our git history...
This is the "old" code that was previously causing the problem:
if (!fileAccess.isExpectedFolder(setupFolder) && !fileAccess.isExpectedFolder(updateFolder)) { |
However, the bug #818 was already fixed some time ago but most probably as a side-effect of some other bugfix or feature (most probably #982).
So if there is no bug we also do not need a bugfix.
I hope not to frustrate anybody involved here and hope you take it as a learning to always first reproduce the issue before fixing it.
Fixes #818