Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1110: Fixed ide status fails with IllegalStateException when being offline #1125

Merged

Conversation

paz-capgemini
Copy link
Contributor

Fixes #1110

  • Skip the checkUpdate step when running the status command while being offline and print warning message that this step was skipped

Screenshot 2025-03-11 103526

@paz-capgemini paz-capgemini self-assigned this Mar 11, 2025
@coveralls
Copy link
Collaborator

coveralls commented Mar 11, 2025

Pull Request Test Coverage Report for Build 13987465222

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 67.688%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/commandlet/StatusCommandlet.java 16 34.07%
Totals Coverage Status
Change from base Build 13977250962: 0.01%
Covered Lines: 7830
Relevant Lines: 11140

💛 - Coveralls

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready for review.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paz-capgemini thanks for your PR. Great that you found the proper fix and both added an automated JUnit test covering it and also tested your changes manually. This is excellent and exemplary 👍
I left a small comment. Either explain why awstest was removed in this story and I resolve or revert that change.
Then we merge your PR.

@hohwille hohwille added this to the release:2025.03.002 milestone Mar 21, 2025
@hohwille
Copy link
Member

hohwille commented Mar 21, 2025

By the way: You forgot to add the issue to the CHANGELOG:
https://github.com/devonfw/IDEasy/blob/main/documentation/DoD.adoc
I can do that for you after the merge, but please consider it for your next PR (in case you may come back to our team). Thanks.

@hohwille hohwille added bugfix status StatusCommandlet (ide status) labels Mar 21, 2025
@hohwille hohwille merged commit c743c42 into devonfw:main Mar 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix status StatusCommandlet (ide status)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

ide status fails with IllegalStateException when offline
4 participants