-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1110: Fixed ide status fails with IllegalStateException when being offline #1125
#1110: Fixed ide status fails with IllegalStateException when being offline #1125
Conversation
Pull Request Test Coverage Report for Build 13987465222Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ready for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paz-capgemini thanks for your PR. Great that you found the proper fix and both added an automated JUnit test covering it and also tested your changes manually. This is excellent and exemplary 👍
I left a small comment. Either explain why awstest
was removed in this story and I resolve or revert that change.
Then we merge your PR.
By the way: You forgot to add the issue to the CHANGELOG: |
Fixes #1110