Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#971: Ability to run "migration script" on update #1038

Merged
merged 45 commits into from
Mar 2, 2023

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Jan 16, 2023

This PR implements the migration command which is executed after devon ide update scripts, for example. The script runs various migration scripts located in the folder DEVON_HOME/scripts/migrations.

Example:
The current IDE version is 2022.03.001 and the user updates the IDE to the latest version. So all migrations scripts > 2022.03.001 will be executed for the migration.

Related issue: #971

@alfeilex alfeilex linked an issue Jan 16, 2023 that may be closed by this pull request
@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) scripts related to shell scripts (bash and CMD) labels Jan 16, 2023
@alfeilex alfeilex removed the bash related to bash shell or scripts label Jan 16, 2023
@github-actions github-actions bot added the bash related to bash shell or scripts label Jan 16, 2023
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex Thanks for your PR. Looks already good to me. 👍
The spot where you integrated the change is fine.
We should discuss if migration should be a commandlet. The impact is that end-users will get this via code-completion and devon help while IMHO it is something internal not intended for end-users. So I would rather move this to the scripts folder out of command folder.
IMHO we should consider creating a documentation/migration.asciidoc file as well.

@github-actions github-actions bot removed the commandlet related to commandlets (scripts/command/*) label Jan 26, 2023
@github-actions github-actions bot added the documentation related to documentation (AsciiDoc) label Jan 26, 2023
@hohwille hohwille added this to the release:2023.02.001 milestone Feb 13, 2023
@hohwille
Copy link
Member

I found a potential conflict of requirements:
#1032 suggests to change the output of devon -v and this PR is using it in order to determine the current version installed.
Maybe we can easily solve this when we address my review suggestion to maintain the version in ${DEVON_IDE_HOME}/.devon.software.version.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex Thanks for this PR. Looks quite good now 👍
Sorry, but I still have some last review comments for rework to make this fully functional.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex Thanks for the update 👍
Ready for merge now.

@hohwille hohwille merged commit 39a7808 into devonfw:master Mar 2, 2023
@alfeilex alfeilex deleted the feature/migration branch March 2, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash related to bash shell or scripts documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to run "migration script" on update
2 participants