-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#971: Ability to run "migration script" on update #1038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfeilex Thanks for your PR. Looks already good to me. 👍
The spot where you integrated the change is fine.
We should discuss if migration
should be a commandlet. The impact is that end-users will get this via code-completion and devon help
while IMHO it is something internal not intended for end-users. So I would rather move this to the scripts
folder out of command
folder.
IMHO we should consider creating a documentation/migration.asciidoc
file as well.
…nto feature/migration
I found a potential conflict of requirements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfeilex Thanks for this PR. Looks quite good now 👍
Sorry, but I still have some last review comments for rework to make this fully functional.
…nto feature/migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfeilex Thanks for the update 👍
Ready for merge now.
This PR implements the
migration
command which is executed afterdevon ide update scripts
, for example. The script runs various migration scripts located in the folderDEVON_HOME/scripts/migrations
.Example:
The current IDE version is
2022.03.001
and the user updates the IDE to the latest version. So all migrations scripts >2022.03.001
will be executed for the migration.Related issue: #971