Skip to content

#1149 Version handling for Issue 1084 #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Jun 6, 2023
Merged

#1149 Version handling for Issue 1084 #1150

merged 39 commits into from
Jun 6, 2023

Conversation

CREITZ25
Copy link
Member

@CREITZ25 CREITZ25 commented May 8, 2023

#1149 Version handling for Issue 1084

@CREITZ25 CREITZ25 self-assigned this May 8, 2023
@github-actions github-actions bot added bash related to bash shell or scripts documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD) labels May 8, 2023
@CREITZ25 CREITZ25 linked an issue May 8, 2023 that may be closed by this pull request
Version handling for Issue #1084 Adapt scripts to use ide-urls #1149
Closed
CREITZ25 added 9 commits May 8, 2023 13:21
@CREITZ25
devonfw#1149 Version handling for Issue 1084
d21d7c8 
devonfw#1149 Version handling for Issue 1084
@CREITZ25
devonfw#1149 Version handling for Issue 1084
671807b 
devonfw#1149 Version handling for Issue 1084
@CREITZ25
devonfw#1149 Version handling for Issue 1084
8330a34 
devonfw#1149 Version handling for Issue 1084
@CREITZ25
devonfw#1149 Version handling for Issue 1084
0c424ed 
devonfw#1149 Version handling for Issue 1084
@CREITZ25
devonfw#1149 Version handling for Issue 1084
c204076 
devonfw#1149 Version handling for Issue 1084
@CREITZ25
devonfw#1149 Version handling for Issue 1084
380e705 
devonfw#1149 Version handling for Issue 1084
@CREITZ25
devonfw#1149 Version handling for Issue 1084
647c8f3 
devonfw#1149 Version handling for Issue 1084
@CREITZ25
devonfw#1149 Version handling for Issue 1084
43911cb 
devonfw#1149 Version handling for Issue 1084
@CREITZ25
devonfw#1149 Version handling for Issue 1084
db3d740 
devonfw#1149 Version handling for Issue 1084
@CREITZ25
Copy link
Member Author

CREITZ25 commented May 8, 2023 •
edited
Loading

function doUpdateUrls added and documented
functions doSetSoftwareVersion and doListSoftwareVersions adapted
works with mirrors and urls
All tested on Windows, Linux and MacOS

@CREITZ25 CREITZ25 marked this pull request as ready for review May 8, 2023 13:01
@CREITZ25 CREITZ25 marked this pull request as draft May 12, 2023 16:12
@CREITZ25 CREITZ25 marked this pull request as ready for review May 12, 2023 17:06
hohwille
hohwille requested changes May 22, 2023
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment •
edited by CREITZ25
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 thanks for your PR. IMHO some things are not correct and need to be reworked.
Will we have the redundancies only for a short time as we later remove the ifs and only keep the ide-urls branch?

@hohwille Yes, the idea is to remove the mirror later and use the if blocks to find the places quickly

@CREITZ25 CREITZ25 marked this pull request as draft May 23, 2023 12:12
@CREITZ25 CREITZ25 marked this pull request as ready for review May 23, 2023 13:37
CREITZ25
CREITZ25 commented May 23, 2023
View reviewed changes
Copy link
Member Author

@CREITZ25 CREITZ25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done, please review again

@CREITZ25 CREITZ25 requested a review from hohwille May 23, 2023 13:38
@CREITZ25 CREITZ25 requested a review from hohwille June 5, 2023 07:16
CREITZ25
CREITZ25 commented Jun 5, 2023
View reviewed changes
Copy link
Member Author

@CREITZ25 CREITZ25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done

@hohwille hohwille added this to the release:2023.06.001 milestone Jun 6, 2023
hohwille
hohwille approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 Excellent. 👍
Ready for merge.

@hohwille hohwille merged commit 43bc42f into devonfw:master Jun 6, 2023
@CREITZ25 CREITZ25 deleted the (feature/#1149-Version-handling-for-Issue-#1084 branch June 6, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@CREITZ25 CREITZ25

Labels
bash related to bash shell or scripts documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD)
Projects
None yet
Milestone
release:2023.07.001
Development

Successfully merging this pull request may close these issues.

Version handling for Issue #1084 Adapt scripts to use ide-urls
2 participants
@CREITZ25 @hohwille