Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface support added #32

Merged
merged 12 commits into from
Feb 11, 2019
Merged

Interface support added #32

merged 12 commits into from
Feb 11, 2019

Conversation

jdiazgon
Copy link
Member

@jdiazgon jdiazgon commented Feb 5, 2019

Addresses #29 and #14. This PR adds interface support on the merger:

  • Added tests for checking the correct merging of interfaces.
  • Added tests for checking the correct merging of methods defined on interfaces.
  • Added tests for checking the correct merging of properties defined on interfaces.
  • Added tests for checking the correct merging of index signatures defined on interfaces.

@jdiazgon
Copy link
Member Author

jdiazgon commented Feb 11, 2019 •
edited
Loading

Also added:

  • The possibility to merge comments defined in class and interface declarations.
  • extends and implements now get merged.
  • Disabled uglify as it does not work with es2015.

@sjimenez77 sjimenez77 merged commit 5c14431 into devonfw:master Feb 11, 2019
@jdiazgon jdiazgon deleted the interface_merge branch February 18, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dario-rodriguez dario-rodriguez dario-rodriguez approved these changes

@sjimenez77 sjimenez77 Awaiting requested review from sjimenez77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdiazgon @dario-rodriguez @sjimenez77