Skip to content

🐞 [ BUGFIX] Broken bin/cover script. #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: fix(README): typos
merged 1 commit into from
Jan 18, 2018
Merged

🐞 [ BUGFIX] Broken bin/cover script. #162

merged 1 commit into from
Jan 18, 2018

Conversation

@snuggs
Copy link
Member

@snuggs snuggs commented Jan 18, 2018 •
edited
Loading

Addresses:
- #160
- #161

@snuggs snuggs self-assigned this Jan 18, 2018
@snuggs
Copy link
Member Author

snuggs commented Jan 18, 2018 •
edited
Loading

@tmornini @brandondees UGHHH DEP Update. Had to force this one in as is blocking some important work. tap-nyc requires explicit requirement of nyc now.

Only one file seems to be covered index.js (and we don't even really use the .js extension over .es). That's a mystery but could be because i've never set anything for nyc. Entire test suite ✅ tho! 🎉

https://github.com/istanbuljs/nyc

capture d ecran 2018-01-18 a 11 38 28

@snuggs snuggs merged commit 1b364c3 into master Jan 18, 2018
@snuggs snuggs deleted the issue/161-bug-in-test-coverage-routine branch January 18, 2018 12:13
@snuggs snuggs mentioned this pull request Jan 18, 2018
Closed
@snuggs snuggs mentioned this pull request Dec 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmornini tmornini Awaiting requested review from tmornini

@brandondees brandondees Awaiting requested review from brandondees

Assignees

@snuggs snuggs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@snuggs