-
-
Notifications
You must be signed in to change notification settings - Fork 17
features/nav-view #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@snuggs Any thoughts? I want to get this merged. |
@Robertchristopher was away for the past week. Back at it again. Have added some commits to the branch. Will push later today. |
@snuggs Can you push up your local commits? I want to see where your head is at. Need to get this merged soon. |
Will do @Robertchristopher ! Please review #54 |
@Robertchristopher I FOUND IT! I forgot had this PR open. This is all we need for |
93faff5
to
3739a4d
Compare
@Robertchristopher rebased this branch. should be good to go now. I've done some interesting things with fragment identifier relative to the PR above. check out http://snuggsi.herokuapp.com and click nav links on the left for example. Seems like this feature should introduce a Also did not have to add the script files to the package.json |
@Robertchristopher @mrbernnz @brandondees @tmornini @btakita @albertoponti @robcole @misscs not too shabby a component this <link rel=import href=//snuggsi.es/nav-view>
<nav-view>
<!-- creates automagic links based on `view` discovery
<a href=#home title='Used for title and link in nav-view'>Used for title and link in nav-view</a>
<a href=#about title='About Us'>About Us</a>
<a href=#contact title='Contact Us'>Contact Us</a>
-->
</nav-view>
<main view id=home role=main title='Used for title and link in nav-view'>
<h1>Home Page</h1>
<p>This is the home page</p>
</main>
<main hidden view id=about role=main title='About Us'>
<h1>About Us</h1>
<p>This is the about page</p>
</main>
<main hidden view id=contact role=main title='Contact Us'>
<h1>Contact Us</h1>
<p>This is the contact page</p>
</main> Demo |
Implemented declarative micro-router that maps url fragments to templates.