Skip to content

Fix #345 Spaces in groupnames #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wurstbrot merged 5 commits into from
Dec 29, 2024
Merged

Fix #345 Spaces in groupnames #346

wurstbrot merged 5 commits into from
Dec 29, 2024

Conversation

@vbakke
Copy link
Collaborator

@vbakke vbakke commented Dec 28, 2024

Fixes #345

  • Space in team names, and team groups now work
  • Removed unnecessary loop in toggleTeamGroupSelection()
  • Fixed: Filter chips are now initialized after teams have been loaded (no longer just a 100ms delay)
  • Fixed: Incorrect background color on hover over
  • Fixed: Team filter initializes with selected color (in sync with the 'All' group)

@vbakke vbakke mentioned this pull request Dec 28, 2024
Closed
@wurstbrot wurstbrot requested a review from 0x41head December 29, 2024 15:35
wurstbrot
wurstbrot approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@wurstbrot wurstbrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

0x41head
0x41head approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@0x41head 0x41head left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the great PR @vbakke

@wurstbrot
Copy link
Collaborator

wurstbrot commented Dec 29, 2024

next time, please sign your commits.

@wurstbrot wurstbrot merged commit 568a4ba into devsecopsmaturitymodel:master Dec 29, 2024
2 checks passed
@vbakke
Copy link
Collaborator Author

vbakke commented Dec 30, 2024

next time, please sign your commits.
Sure. I'll look into that before the next pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wurstbrot wurstbrot wurstbrot approved these changes

@0x41head 0x41head 0x41head approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Team and group names with space fail

3 participants

@vbakke @wurstbrot @0x41head