Remove sideeffect when opening modal dialog #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Any comments on this @0x41head? Are you able to reproduce the issue?
|
0x41head
approved these changes
Jan 13, 2025
Collaborator
0x41head
left a comment
0x41head
left a comment
There was a problem hiding this comment.
I apologize for the delay in getting back to you.
I managed to replicate the issue, and your PR resolves it flawlessly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Circular Heatmap, opening the modal dialog displaying the Activity Details, will affect
this.YamlObject, and thus affect the export ofgenerated.yaml, with an extranavigationExtrasfor all activities that have been opened.The fix was to assign a shallow copy of the activity, before adding the
navigationExtras.