feat: add support for skipping hibernated apps in bulk deploy #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunjaindev
requested review from
vivek-devtron and
vikramdevtron
as code owners
github-actions
bot
added
the
PR:Issue-verification-failed
…nto feat/skip-hibernated-deploy
…nto feat/skip-hibernated-deploy
AbhishekA1509
requested changes
Apr 9, 2025
| @@ -157,6 +157,7 @@ export default function NavigationRoutes() { | |||
| isManifestScanningEnabled: false, | |||
| canOnlyViewPermittedEnvOrgLevel: false, | |||
| featureGitOpsFlags: structuredClone(DEFAULT_GIT_OPS_FEATURE_FLAGS), | |||
| deployUnhibernatedAppOnly: false, | |||
| @@ -339,6 +340,7 @@ export default function NavigationRoutes() { | |||
| isManifestScanningEnabled: false, | |||
| canOnlyViewPermittedEnvOrgLevel: false, | |||
| featureGitOpsFlags: structuredClone(DEFAULT_GIT_OPS_FEATURE_FLAGS), | |||
| deployUnhibernatedAppOnly: false, | |||
There was a problem hiding this comment.
Lets derive the fallbacks from newly made const as suggested.
| @@ -892,7 +915,7 @@ export default function BulkCDTrigger({ | |||
| closePopup={closeBulkCDModal} | |||
| responseList={responseList} | |||
| isLoading={isLoading} | |||
| onClickRetryBuild={onClickTriggerBulkCD} | |||
| onClickRetryBuild={triggerBulkCD} | |||
There was a problem hiding this comment.
This is a bug we are not sending appsToRetry here
| <button | ||
| type="button" | ||
| className="dc__transparent flex icon-dim-24" | ||
| <h2 className="fs-16 fw-6 lh-1-5 m-0">Deploy to {appList[0].envName}</h2> |
github-actions
bot
added
PR:Ready-to-Review
| @@ -1482,6 +1483,7 @@ export default function EnvTriggerView({ filteredAppIds, isVirtualEnv }: AppGrou | |||
| ...(getRuntimeParamsPayload | |||
| ? { runtimeParamsPayload: getRuntimeParamsPayload(runtimeParams[currentAppId] ?? []) } | |||
| : {}), | |||
| skipIfHibernated: skipIfHibernated, | |||
There was a problem hiding this comment.
Suggested change
| skipIfHibernated: skipIfHibernated, | |
| skipIfHibernated, |
| @@ -848,8 +856,22 @@ export default function BulkCDTrigger({ | |||
|
|
|||
| const renderFooterSection = (): JSX.Element => { | |||
| const isDeployButtonDisabled: boolean = isDeployDisabled() | |||
| const showSkipHibernatedCheckbox = | |||
| stage === DeploymentNodeType.CD && !!SkipHibernatedCheckbox && canFetchHelmAppStatus | |||
There was a problem hiding this comment.
Pls confirm if we should show this in PRE/POST CD
AbhishekA1509
previously approved these changes
Apr 10, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes devtron-labs/devtron#6359
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: