feature: add EKS create cluster #2631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show Add environment button against unmapped namespaces
feat: add environment column in namespace list
…board into feat/add-environment-ns-list
Elessar1802
requested review from
vivek-devtron and
vikramdevtron
as code owners
github-actions
bot
added
the
PR:Issue-verification-failed
AbhishekA1509
requested changes
Apr 7, 2025
| @@ -400,7 +401,9 @@ export const ClusterEnvironmentDrawer = ({ | |||
| <Drawer position="right" width="800px" onEscape={hideClusterDrawer} onClose={hideClusterDrawer}> | |||
| <div className="h-100 bg__primary flexbox-col" onClick={stopPropagation}> | |||
| <div className="flexbox dc__align-items-center dc__content-space dc__border-bottom bg__primary py-12 px-20"> | |||
| <h3 className="m-0 fs-16 fw-6 lh-1-43">{id ? 'Edit Environment' : 'Add Environment'}</h3> | |||
| <h3 className="m-0 fs-16 fw-6 lh-1-43"> | |||
| @@ -83,7 +83,7 @@ export const URLS = { | |||
| GLOBAL_CONFIG_GITOPS: '/global-config/gitops', | |||
| GLOBAL_CONFIG_DOCKER: '/global-config/docker', | |||
| GLOBAL_CONFIG_CLUSTER: '/global-config/cluster-env', | |||
| GLOBAL_CONFIG_CREATE_CLUSTER: '/global-config/cluster-env/create/cluster', | |||
| GLOBAL_CONFIG_CREATE_CLUSTER: '/global-config/cluster-env/create/cluster/:type', | |||
There was a problem hiding this comment.
| @@ -77,6 +79,40 @@ export const getResourceData = async ({ | |||
| return parseNodeList(response) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Pls verify silver surfer once
| const { result } = await getNamespaceListMin(clusterId) | ||
| const [{ environments }] = result | ||
|
|
||
| const response = await getK8sResourceList( |
There was a problem hiding this comment.
Its common in else block and here, can common out.
| @@ -77,6 +79,40 @@ export const getResourceData = async ({ | |||
| return parseNodeList(response) | |||
| } | |||
|
|
|||
| if (selectedResource.gvk.Kind.toLowerCase() === Nodes.Namespace.toLowerCase()) { | |||
| const { result } = await getNamespaceListMin(clusterId) | |||
There was a problem hiding this comment.
We should send abortController as well
| @@ -382,6 +386,14 @@ const BaseResourceListContent = ({ | |||
| } | |||
| } | |||
|
|
|||
| const getAddEnvironmentClickHandler = (namespace: string) => () => { | |||
| const environmentFormData = { | |||
There was a problem hiding this comment.
There must be a type like: AddEnvironmentFormPrefilledInfoType
| export const SIDEBAR_CONFIG: SidebarConfigType = { | ||
| [CreateClusterTypeEnum.CONNECT_CLUSTER]: { | ||
| title: 'Connect cluster', | ||
| iconName: 'ic-ci-linked' as IconName, |
There was a problem hiding this comment.
Can sync as to why we had to use as.
|
|
||
| return ( | ||
| <NavLink | ||
| className={`dc__transparent flex left dc__gap-8 py-6 px-8 br-4 ${isSelected ? 'bcb-1' : 'dc__hover-n50'}`} |
| onEscape={handleRedirectToClusterList} | ||
| onClose={handleRedirectToClusterList} | ||
| > | ||
| <dialog |
There was a problem hiding this comment.
We should not use dialog here, should be catered in Drawer component later
| onClick={stopPropagation} | ||
| > | ||
| <header className="px-20 py-12 lh-24 flexbox dc__content-space dc__align-items-center dc__border-bottom"> | ||
| <span className="fs-16 fw-6 dc__first-letter-capitalize">New Cluster</span> |
There was a problem hiding this comment.
Suggestion: Can be a h tag
feat: created clusters in cluster listing and cluster configuration in cluster overview
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: