Skip to content

feat: banner component #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 101 commits into from
May 9, 2025
Merged

feat: banner component #2672

merged 101 commits into from
May 9, 2025

Conversation

shivani170
Copy link
Contributor

@shivani170 shivani170 commented Apr 24, 2025

Description

Banner Integration for cases like:

  • INTERNET_CONNECTIVITY 
    
  • VERSION_UPDATE
    
  • ANNOUNCEMENT
    
  • LICENSE
    
  • INCOMPATIBLE_MICROSERVICES 
    

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2150

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

INTERNET_CONNECTIVITY isAirgapped : Disable !sAirgapped : Done
ANNOUNCEMENT Done
VERSION_UPDATE  
INCOMPATIBLE_MICROSERVICES Yes
LICENSE Done



Enterprise

  • In case: Your trial license will expire in ${remainingTimeString}
INTERNET_CONNECTIVITY isAirgapped : Disable !isAirgapped:
ANNOUNCEMENT Yes
VERSION_UPDATE Yes
INCOMPATIBLE_MICROSERVICES Yes
LICENSE NA


  • Airgapped
  • Reload
  • Announcement
  • Licensing
  • Online/Ofline

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Apr 24, 2025
vivek-devtron
vivek-devtron previously approved these changes May 6, 2025
vivek-devtron
vivek-devtron previously approved these changes May 9, 2025
AbhishekA1509
AbhishekA1509 previously approved these changes May 9, 2025
@shivani170 shivani170 dismissed stale reviews from AbhishekA1509 and vivek-devtron via ee98299 May 9, 2025 12:19
Copy link

sonarqubecloud bot commented May 9, 2025

@shivani170 shivani170 merged commit e28dca8 into develop May 9, 2025
10 checks passed
@shivani170 shivani170 deleted the feat/banner branch May 9, 2025 12:22
@shivani170 shivani170 self-assigned this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants