fix: replay attacks after canister migration #7787
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
commented
Nov 26, 2025
|
|
||
| for _ in 0..100 { | ||
| // advance time by a lot such that the task which waits 5m can succeed quickly. | ||
| // advance time by a lot such that the task which waits 5m and 30s can succeed quickly. |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| // advance time by a lot such that the task which waits 5m and 30s can succeed quickly. | |
| // advance time by a lot such that the task which waits 6m can succeed quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents replay attacks after canister migration by waiting at least 6 minutes: 5 minutes and 30 seconds (maximum ingress expiry enforced by ingress validator) and 30 seconds (to account for a clock drift between the two subnets).