Skip to content

chore: removes _language-service command #4220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

# UNRELEASED

### chore: removes the outdated `_language-service` command

### feat: Support 'follow' mode for 'dfx canister logs'
Support `follow` mode for `dfx canister logs`
- `--follow` to fetch logs continuously until interrupted with `Ctrl+C`
Expand Down
8 changes: 4 additions & 4 deletions src/dfx/assets/prepare_assets.rs
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ fn write_binary_cache(
BufWriter::new(File::create(out_dir.join("binary_cache.tgz")).unwrap()),
Compression::new(6),
));
for (path, bin) in bins.into_iter().chain(
["moc", "mo-doc", "mo-ide"]
.map(|bin| (bin.into(), bin_tars.remove(Path::new(bin)).unwrap())),
) {
for (path, bin) in bins
.into_iter()
.chain(["moc", "mo-doc"].map(|bin| (bin.into(), bin_tars.remove(Path::new(bin)).unwrap())))
{
let mut header = Header::new_gnu();
header.set_size(bin.len() as u64);
header.set_mode(0o500);
Expand Down
162 changes: 0 additions & 162 deletions src/dfx/src/commands/language_service.rs

This file was deleted.

4 changes: 0 additions & 4 deletions src/dfx/src/commands/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ mod generate;
mod identity;
mod info;
mod killall;
mod language_service;
mod ledger;
mod new;
mod ping;
Expand Down Expand Up @@ -53,8 +52,6 @@ pub enum DfxCommand {
Identity(identity::IdentityOpts),
Info(info::InfoOpts),
Killall(killall::KillallOpts),
#[command(name = "_language-service")]
LanguageServices(language_service::LanguageServiceOpts),
Ledger(ledger::LedgerOpts),
New(new::NewOpts),
Ping(ping::PingOpts),
Expand Down Expand Up @@ -90,7 +87,6 @@ pub fn exec(env: &dyn Environment, cmd: DfxCommand) -> DfxResult {
DfxCommand::Identity(v) => identity::exec(env, v),
DfxCommand::Info(v) => info::exec(env, v),
DfxCommand::Killall(v) => killall::exec(env, v),
DfxCommand::LanguageServices(v) => language_service::exec(env, v),
DfxCommand::Ledger(v) => ledger::exec(env, v),
DfxCommand::New(v) => new::exec(env, v),
DfxCommand::Ping(v) => ping::exec(env, v),
Expand Down
6 changes: 3 additions & 3 deletions src/dfx/src/lib/package_arguments.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ use fn_error_context::context;
use std::path::Path;
use std::process::Command;

/// Package arguments for moc or mo-ide as returned by
/// a package tool like https://github.com/kritzcreek/vessel
/// or, if there is no package tool, the base library.
/// Package arguments for moc as returned by a package tool like
/// https://github.com/kritzcreek/vessel or, if there is no package
/// tool, the base library.
pub type PackageArguments = Vec<String>;

#[context("Failed to load package arguments.")]
Expand Down