Open
Conversation
Member
|
@dominikzogg Would you mind taking a look at this (and #59 in retrospect) if you get a chance? This looks heavier than I'd like to merge on a whim and I don't have the time to look at this for at least a week or so. @c960657 thanks for your help on this! I definitely like the direction. :) If I can get another set of eyes on it we can probably get it merged. |
c960657
force-pushed
the
mapping-driver-factory
branch
from
f1fbcdb to
d1e6dde
Compare
c960657
force-pushed
the
mapping-driver-factory
branch
from
d1e6dde to
46b2f39
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a mapping driver factory, orm.mapping.factory, following the same pattern as orm.cache.factory.
It supports custom mapping drivers like it has been proposed for cache drivers in #59.
The factory methods requires a Configuration instance to be passed. This is only used by the "annotation" driver and could be avoided by inlining the code in Doctrine\ORM\Configuration::newDefaultAnnotationDriver(). This would make the API cleaner but create make a stronger coupling to Doctrine ORM, so I kept the existing implementation. Agree?